Fixed null pointer when cant find a server

tags: #fix

src/main/java/seng302/App.java

@@ -68,7 +68,7 @@ public class App extends Application {
     @Override
     public void start(Stage primaryStage) throws Exception {
         Parent root = FXMLLoader.load(getClass().getResource("/views/StartScreenView.fxml"));
-        primaryStage.setTitle("RaceVision");
+        primaryStage.setTitle("Party Parrots at Sea");
         Scene scene = new Scene(root, 1530, 960);
         scene.getStylesheets().add(getClass().getResource("/css/master.css").toString());
         primaryStage.setScene(scene);

src/main/java/seng302/visualiser/GameClient.java

@@ -74,6 +74,7 @@ public class GameClient {
             startClientToServerThread(ipAddress, portNumber);
             socketThread.addDisconnectionListener((cause) -> {
                 showConnectionError(cause);
+                tearDownConnection();
                 Platform.runLater(this::loadStartScreen);
             });
             socketThread.addStreamObserver(this::parsePackets);
@@ -91,7 +92,10 @@ public class GameClient {
                 lobbyController.setCourseName("");
             }
 
-            lobbyController.addCloseListener((exitCause) -> this.loadStartScreen());
+            lobbyController.addCloseListener((exitCause) -> {
+                this.tearDownConnection();
+                this.loadStartScreen();
+            });
             this.lobbyController = lobbyController;
         } catch (IOException ioe) {
             showConnectionError("Unable to find server");
@@ -109,6 +113,7 @@ public class GameClient {
         try {
             startClientToServerThread(ipAddress, portNumber);
             socketThread.addDisconnectionListener((cause) -> {
+                this.tearDownConnection();
                 Platform.runLater(this::loadStartScreen);
             });
             LobbyController lobbyController = loadLobby();
@@ -129,8 +134,7 @@ public class GameClient {
                     lobbyController.disableReadyButton();
                     server.startGame();
                 } else if (exitCause == CloseStatus.LEAVE) {
-                    server.terminate();
-                    server = null;
+                    tearDownConnection();
                     loadStartScreen();
                 }
             });
@@ -141,12 +145,20 @@ public class GameClient {
         }
     }
 
-    private void loadStartScreen() {
+    private void tearDownConnection() {
         socketThread.setSocketToClose();
         if (server != null) {
             server.terminate();
             server = null;
         }
+    }
+
+    private void loadStartScreen() {
+//        socketThread.setSocketToClose();
+//        if (server != null) {
+//            server.terminate();
+//            server = null;
+//        }
         FXMLLoader fxmlLoader = new FXMLLoader(
             getClass().getResource("/views/StartScreenView.fxml"));
         try {

src/main/resources/views/StartScreenView.fxml

@@ -20,7 +20,9 @@
    <children>
       <GridPane fx:id="startScreen2" layoutX="365.0" layoutY="285.0" nodeOrientation="LEFT_TO_RIGHT" prefWidth="800.0" style="-fx-background-color: #2C2c36;">
          <children>
-            <Label alignment="CENTER" text="Welcome to Race Vision" textFill="WHITE" GridPane.columnSpan="2147483647" GridPane.halignment="CENTER" GridPane.rowIndex="1" GridPane.valignment="BOTTOM">
+            <Label alignment="CENTER" text="Party Parrots at Sea" textFill="WHITE"
+              GridPane.columnSpan="2147483647" GridPane.halignment="CENTER" GridPane.rowIndex="1"
+              GridPane.valignment="BOTTOM">
                <font>
                   <Font size="40.0" />
                </font>