Game state now updates based on boat position. Arrows drawn as boat travels course. Currently do not point in correct direction, also the sparkline does not work.

#bug #refactor #implement #story[1118]

src/main/java/seng302/visualiser/ClientToServerThread.java

@@ -21,12 +21,12 @@ import javafx.scene.control.Alert.AlertType;
 import javafx.scene.control.ButtonType;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import seng302.gameServer.server.messages.BoatAction;
-import seng302.gameServer.server.messages.BoatActionMessage;
-import seng302.gameServer.server.messages.ClientType;
-import seng302.gameServer.server.messages.Message;
-import seng302.gameServer.server.messages.RegistrationRequestMessage;
-import seng302.gameServer.server.messages.RegistrationResponseStatus;
+import seng302.gameServer.messages.BoatAction;
+import seng302.gameServer.messages.BoatActionMessage;
+import seng302.gameServer.messages.ClientType;
+import seng302.gameServer.messages.Message;
+import seng302.gameServer.messages.RegistrationRequestMessage;
+import seng302.gameServer.messages.RegistrationResponseStatus;
 import seng302.model.stream.packets.PacketType;
 import seng302.model.stream.packets.StreamPacket;
 

src/main/java/seng302/visualiser/GameClient.java

@@ -13,7 +13,7 @@ import javafx.scene.Node;
 import javafx.scene.input.KeyEvent;
 import javafx.scene.layout.Pane;
 import seng302.gameServer.MainServerThread;
-import seng302.gameServer.server.messages.BoatAction;
+import seng302.gameServer.messages.BoatAction;
 import seng302.model.ClientYacht;
 import seng302.model.RaceState;
 import seng302.model.stream.packets.StreamPacket;
@@ -141,17 +141,7 @@ public class GameClient {
     }
 
     private void loadRaceView() {
-        FXMLLoader fxmlLoader = new FXMLLoader(
-            RaceViewController.class.getResource("/views/RaceView.fxml"));
-        try {
-            final Node node = fxmlLoader.load();
-            Platform.runLater(() -> {
-                holderPane.getChildren().clear();
-                holderPane.getChildren().add(node);
-            });
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+        FXMLLoader fxmlLoader = loadFXMLToHolder("/views/RaceView.fxml");
         holderPane.getScene().setOnKeyPressed(this::keyPressed);
         holderPane.getScene().setOnKeyReleased(this::keyReleased);
         raceView = fxmlLoader.getController();
@@ -160,17 +150,23 @@ public class GameClient {
     }
 
     private void loadFinishScreenView() {
+        loadFXMLToHolder("/views/FinishScreenView.fxml");
+    }
+
+    private FXMLLoader loadFXMLToHolder(String fxmlLocation) {
         FXMLLoader fxmlLoader = new FXMLLoader(
-            getClass().getResource("/views/FinishScreenView.fxml"));
+            getClass().getResource(fxmlLocation)
+        );
         try {
-            final Node finishScreenFX = fxmlLoader.load();
+            final Node fxmlLoaderFX = fxmlLoader.load();
             Platform.runLater(() -> {
                 holderPane.getChildren().clear();
-                holderPane.getChildren().add(finishScreenFX);
+                holderPane.getChildren().add(fxmlLoaderFX);
             });
         } catch (IOException e) {
             e.printStackTrace();
         }
+        return fxmlLoader;
     }
 
     private void parsePackets() {
@@ -247,8 +243,8 @@ public class GameClient {
     private void updatePosition(PositionUpdateData positionData) {
         if (positionData.getType() == DeviceType.YACHT_TYPE) {
             if (allXMLReceived() && allBoatsMap.containsKey(positionData.getDeviceId())) {
-                ClientYacht clientYacht = allBoatsMap.get(positionData.getDeviceId());
-                clientYacht.updateLocation(positionData.getLat(),
+                ClientYacht yacht = allBoatsMap.get(positionData.getDeviceId());
+                yacht.updateLocation(positionData.getLat(),
                     positionData.getLon(), positionData.getHeading(),
                     positionData.getGroundSpeed());
             }
@@ -265,14 +261,26 @@ public class GameClient {
      */
     private void updateMarkRounding(MarkRoundingData roundingData) {
         if (allXMLReceived()) {
-            ClientYacht clientYacht = allBoatsMap.get(roundingData.getBoatId());
-            clientYacht.setMarkRoundingTime(roundingData.getTimeStamp());
-            clientYacht.updateTimeSinceLastMarkProperty(
-                raceState.getRaceTime() - roundingData.getTimeStamp());
-            clientYacht.setLastMarkRounded(
-                courseData.getCompoundMarks().get(
-                    roundingData.getMarkId()
-                )
+            ClientYacht yacht = allBoatsMap.get(roundingData.getBoatId());
+            int placing = 1;
+            int originalPlacing = yacht.getPlacing();
+            for (ClientYacht otherYacht : allBoatsMap.values()) {
+                if (otherYacht != yacht && yacht.getLegNumber() + 1 <= otherYacht.getLegNumber()) {
+                    placing++;
+                }
+            }
+            if (placing != originalPlacing) {
+                yacht.setPlacing(placing);
+                for (ClientYacht otherYacht : allBoatsMap.values()) {
+                    if (otherYacht.getPlacing() < placing) {
+                        otherYacht.setPlacing(otherYacht.getPlacing() + 1);
+                    }
+                }
+            }
+            yacht.roundMark(
+                courseData.getCompoundMarks().get(roundingData.getMarkId()),
+                roundingData.getTimeStamp(),
+                raceState.getRaceTime() - roundingData.getTimeStamp()
             );
         }
     }
@@ -280,35 +288,33 @@ public class GameClient {
     private void processRaceStatusUpdate(RaceStatusData data) {
         if (allXMLReceived()) {
             raceState.updateState(data);
-            if (raceView != null) {
-                raceView.getGameView().setWindDir(raceState.getWindDirection());
-            }
             boolean raceFinished = true;
             for (ClientYacht yacht : allBoatsMap.values()) {
                 if (yacht.getBoatStatus() != 3) {
                     raceFinished = false;
                 }
             }
-            if (raceFinished == true) {
+            if (raceFinished) {
                 loadFinishScreenView();
             }
 
             for (long[] boatData : data.getBoatData()) {
-                ClientYacht clientYacht = allBoatsMap.get((int) boatData[0]);
-                clientYacht.setEstimateTimeTillNextMark(raceState.getRaceTime() - boatData[1]);
-                clientYacht.setEstimateTimeAtFinish(boatData[2]);
+                ClientYacht yacht = allBoatsMap.get((int) boatData[0]);
+                yacht.setEstimateTimeTillNextMark(raceState.getRaceTime() - boatData[1]);
+                yacht.setEstimateTimeAtFinish(boatData[2]);
                 int legNumber = (int) boatData[3];
-                clientYacht.setLegNumber(legNumber);
-                clientYacht.setBoatStatus((int) boatData[4]);
-                if (legNumber != clientYacht.getLegNumber()) {
-                    int placing = 1;
-                    for (ClientYacht otherClientYacht : allBoatsMap.values()) {
-                        if (otherClientYacht.getSourceId() != boatData[0] &&
-                            clientYacht.getLegNumber() <= otherClientYacht.getLegNumber())
-                            placing++;
-                    }
-                    clientYacht.setPositionInteger(placing);
-                }
+//                yacht.setLegNumber(legNumber);
+                yacht.setBoatStatus((int) boatData[4]);
+//                if (legNumber != yacht.getLegNumber()) {
+//                    System.out.println("WHAT THE FUCK IT WORKS????");
+//                    int placing = 1;
+//                    for (ClientYacht otherClientYacht : allBoatsMap.values()) {
+//                        if (otherClientYacht.getSourceId() != boatData[0] &&
+//                            yacht.getLegNumber() <= otherClientYacht.getLegNumber())
+//                            placing++;
+//                    }
+//                    yacht.setPlacing(placing);
+//                }
             }
         }
     }
@@ -347,7 +353,7 @@ public class GameClient {
             //TODO 12/07/17 Determine the sail state and send the appropriate packet (eg. if sails are in, send a sail out packet)
             case SHIFT:  // sails in/sails out
                 socketThread.sendBoatAction(BoatAction.SAILS_IN);
-                raceView.getGameView().getPlayerYacht().toggleSail();
+                allBoatsMap.get(socketThread.getClientId()).toggleSail();
                 break;
             case PAGE_UP:
             case PAGE_DOWN:
@@ -365,7 +371,11 @@ public class GameClient {
     private void showCollisionAlert(YachtEventData yachtEventData) {
         // 33 is the agreed code to show collision
         if (yachtEventData.getEventId() == 33) {
-            raceView.showCollision(yachtEventData.getSubjectId());
+            raceState.storeCollision(
+                allBoatsMap.get(
+                    yachtEventData.getSubjectId().intValue()
+                )
+            );
         }
     }
 }

src/main/java/seng302/visualiser/GameView.java

@@ -7,7 +7,6 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ThreadLocalRandom;
-
 import javafx.animation.AnimationTimer;
 import javafx.animation.KeyFrame;
 import javafx.animation.KeyValue;
@@ -25,8 +24,8 @@ import javafx.scene.paint.Paint;
 import javafx.scene.shape.Circle;
 import javafx.scene.shape.Polygon;
 import javafx.scene.text.Text;
-import seng302.model.ClientYacht;
 import javafx.util.Duration;
+import seng302.model.ClientYacht;
 import seng302.model.Colors;
 import seng302.model.GeoPoint;
 import seng302.model.Limit;
@@ -34,7 +33,12 @@ import seng302.model.mark.CompoundMark;
 import seng302.model.mark.Corner;
 import seng302.model.mark.Mark;
 import seng302.utilities.GeoUtility;
-import seng302.visualiser.fxObjects.*;
+import seng302.visualiser.fxObjects.AnnotationBox;
+import seng302.visualiser.fxObjects.BoatObject;
+import seng302.visualiser.fxObjects.CourseBoundary;
+import seng302.visualiser.fxObjects.Gate;
+import seng302.visualiser.fxObjects.MarkArrowFactory;
+import seng302.visualiser.fxObjects.Marker;
 import seng302.visualiser.map.Boundary;
 import seng302.visualiser.map.CanvasMap;
 
@@ -74,6 +78,7 @@ public class GameView extends Pane {
     private Group boatObjectGroup = new Group();
     private Group trails = new Group();
     private Group markers = new Group();
+    private List<CompoundMark> course = new ArrayList<>();
 
     private ImageView mapImage = new ImageView();
 
@@ -212,6 +217,20 @@ public class GameView extends Pane {
      */
     public void updateCourse(List<CompoundMark> newCourse, List<Corner> sequence) {
         markerObjects = new HashMap<>();
+
+        for (Corner corner : sequence) { //Makes course out of all compound marks.
+            for (CompoundMark compoundMark : newCourse) {
+                if (corner.getCompoundMarkID() == compoundMark.getId()) {
+                    course.add(compoundMark);
+                }
+            }
+        }
+        int j = 0;
+        for (CompoundMark cm : course) {
+            System.out.println(cm.getId() + " " + j++);
+            System.out.println(cm.toString());
+        }
+
         final List<Gate> gates = new ArrayList<>();
         Paint colour = Color.BLACK;
         //Creates new markers
@@ -344,23 +363,23 @@ public class GameView extends Pane {
 
     /**
      * Draws all the boats.
-     * @param  clientYachts The yachts to set in the race
+     * @param  yachts The yachts to set in the race
      */
-    public void setBoats(List<ClientYacht> clientYachts) {
+    public void setBoats(List<ClientYacht> yachts) {
         BoatObject newBoat;
         final List<Group> wakes = new ArrayList<>();
-        for (ClientYacht clientYacht : clientYachts) {
+        for (ClientYacht yacht : yachts) {
             Paint colour = Colors.getColor();
             newBoat = new BoatObject();
             newBoat.setFill(colour);
-            boatObjects.put(clientYacht, newBoat);
-            createAndBindAnnotationBox(clientYacht, colour);
+            boatObjects.put(yacht, newBoat);
+            createAndBindAnnotationBox(yacht, colour);
 //            wakesGroup.getChildren().add(newBoat.getWake());
             wakes.add(newBoat.getWake());
             boatObjectGroup.getChildren().add(newBoat);
             trails.getChildren().add(newBoat.getTrail());
             // TODO: 1/08/17 Make this less vile to look at.
-            clientYacht.addLocationListener((boat, lat, lon, heading, sailIn, velocity) -> {
+            yacht.addLocationListener((boat, lat, lon, heading, sailIn, velocity) -> {
                 BoatObject bo = boatObjects.get(boat);
                 Point2D p2d = findScaledXY(lat, lon);
                 bo.moveTo(p2d.getX(), p2d.getY(), heading, velocity, sailIn, windDir);
@@ -384,11 +403,11 @@ public class GameView extends Pane {
         });
     }
 
-    private void createAndBindAnnotationBox(ClientYacht clientYacht, Paint colour) {
+    private void createAndBindAnnotationBox(ClientYacht yacht, Paint colour) {
         AnnotationBox newAnnotation = new AnnotationBox();
         newAnnotation.setFill(colour);
         newAnnotation.addAnnotation(
-            "name", "Player: " + clientYacht.getShortName()
+            "name", "Player: " + yacht.getShortName()
         );
 //        newAnnotation.addAnnotation(
 //            "velocity",
@@ -411,7 +430,7 @@ public class GameView extends Pane {
 //                return format.format(time);
 //            }
 //        );
-        annotations.put(clientYacht, newAnnotation);
+        annotations.put(yacht, newAnnotation);
     }
 
     private void drawFps(Double fps) {
@@ -613,7 +632,6 @@ public class GameView extends Pane {
         timer.stop();
     }
 
-
     public void setWindDir(double windDir) {
         this.windDir = windDir;
     }
@@ -626,11 +644,18 @@ public class GameView extends Pane {
         return playerYacht;
     }
 
-
     public void setBoatAsPlayer (ClientYacht playerYacht) {
         this.playerYacht = playerYacht;
         this.playerYacht.toggleSail();
         boatObjects.get(playerYacht).setAsPlayer();
+        CompoundMark currentMark = course.get(playerYacht.getLegNumber());
+        for (Mark mark : currentMark.getMarks()) {
+            markerObjects.get(mark).showExitArrow();
+        }
+        CompoundMark destination = course.get(playerYacht.getLegNumber() + 1);
+        for (Mark mark : destination.getMarks()) {
+            markerObjects.get(mark).showEnterArrow();
+        }
         annotations.get(playerYacht).addAnnotation(
             "velocity",
             playerYacht.getVelocityProperty(),
@@ -642,6 +667,24 @@ public class GameView extends Pane {
             annotationsGroup.getChildren().remove(annotations.get(playerYacht));
             gameObjects.add(annotations.get(playerYacht));
         });
+        playerYacht.addMarkRoundingListener(this::updateMarkArrows);
+    }
+
+    private void updateMarkArrows (ClientYacht yacht, CompoundMark compoundMark, int legNumber) {
+        //Only show arrows for this and next leg.
+        for (Mark mark : compoundMark.getMarks()) {
+            markerObjects.get(mark).showExitArrow();
+        }
+        CompoundMark nextMark = course.get(legNumber);
+        for (Mark mark : nextMark.getMarks()) {
+            markerObjects.get(mark).showEnterArrow();
+        }
+        if (legNumber - 2 >= 0) {
+            CompoundMark lastMark = course.get(Math.max(0, legNumber - 2));
+            for (Mark mark : lastMark.getMarks()) {
+                markerObjects.get(mark).hideAllArows();
+            }
+        }
     }
 
     /**
@@ -651,32 +694,30 @@ public class GameView extends Pane {
      * @param collisionPoint yacht collision point
      */
     public void drawCollision(GeoPoint collisionPoint) {
-        Platform.runLater(() -> {
-            Point2D point = findScaledXY(collisionPoint);
-            double circleRadius = 0.0;
-            Circle circle = new Circle(point.getX(), point.getY(), circleRadius, Color.RED);
-            gameObjects.add(circle);
+        Point2D point = findScaledXY(collisionPoint);
+        double circleRadius = 0.0;
+        Circle circle = new Circle(point.getX(), point.getY(), circleRadius, Color.RED);
 
-            circle.setFill(Color.TRANSPARENT);
-            circle.setStroke(Color.RED);
-            circle.setStrokeWidth(3);
+        circle.setFill(Color.TRANSPARENT);
+        circle.setStroke(Color.RED);
+        circle.setStrokeWidth(3);
 
-            Timeline timeline = new Timeline();
-            timeline.setCycleCount(1);
+        Timeline timeline = new Timeline();
+        timeline.setCycleCount(1);
 
-            KeyFrame keyframe1 = new KeyFrame(Duration.ZERO,
-                new KeyValue(circle.radiusProperty(), 0),
-                new KeyValue(circle.strokeProperty(), Color.TRANSPARENT));
-            KeyFrame keyFrame2 = new KeyFrame(new Duration(1000),
-                new KeyValue(circle.radiusProperty(), 50),
-                new KeyValue(circle.strokeProperty(), Color.RED));
-            KeyFrame keyFrame3 = new KeyFrame(new Duration(1500),
-                new KeyValue(circle.strokeProperty(), Color.TRANSPARENT));
+        KeyFrame keyframe1 = new KeyFrame(Duration.ZERO,
+            new KeyValue(circle.radiusProperty(), 0),
+            new KeyValue(circle.strokeProperty(), Color.TRANSPARENT));
+        KeyFrame keyFrame2 = new KeyFrame(new Duration(1000),
+            new KeyValue(circle.radiusProperty(), 50),
+            new KeyValue(circle.strokeProperty(), Color.RED));
+        KeyFrame keyFrame3 = new KeyFrame(new Duration(1500),
+            new KeyValue(circle.strokeProperty(), Color.TRANSPARENT));
 
-            timeline.getKeyFrames().addAll(keyframe1, keyFrame2, keyFrame3);
-            timeline.play();
+        timeline.getKeyFrames().addAll(keyframe1, keyFrame2, keyFrame3);
 
-            timeline.setOnFinished(event -> gameObjects.remove(circle));
-        });
+        Platform.runLater(() -> gameObjects.add(circle));
+        timeline.setOnFinished(event -> Platform.runLater(() -> gameObjects.remove(circle)));
+        timeline.play();
     }
 }

src/main/java/seng302/visualiser/controllers/FinishScreenViewController.java

@@ -63,7 +63,7 @@ public class FinishScreenViewController implements Initializable {
 
     public void setFinishers(List<ClientYacht> participants) {
         List<ClientYacht> sorted = new ArrayList<>(participants);
-        sorted.sort(Comparator.comparingInt(ClientYacht::getPositionInteger));
+        sorted.sort(Comparator.comparingInt(ClientYacht::getPlacing));
         finishOrderTable.getItems().setAll(sorted);
     }
 

src/main/java/seng302/visualiser/controllers/RaceViewController.java

@@ -34,8 +34,8 @@ import javafx.scene.text.Text;
 import javafx.stage.Stage;
 import javafx.stage.StageStyle;
 import javafx.util.StringConverter;
-import seng302.model.ClientYacht;
 import seng302.model.RaceState;
+import seng302.model.ClientYacht;
 import seng302.model.mark.CompoundMark;
 import seng302.model.mark.Mark;
 import seng302.model.stream.xml.parser.RaceXMLData;
@@ -79,6 +79,7 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
     private GameView gameView;
     private RaceState raceState;
 
+    private Timeline timerTimeline;
     private Timer timer = new Timer();
     private List<Series<String, Double>> sparkLineData = new ArrayList<>();
     private ImportantAnnotationsState importantAnnotations;
@@ -100,8 +101,7 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
     }
 
     public void loadRace (
-        Map<Integer, ClientYacht> participants, RaceXMLData raceData, RaceState raceState,
-        ClientYacht player
+        Map<Integer, ClientYacht> participants, RaceXMLData raceData, RaceState raceState, ClientYacht player
     ) {
         this.participants = participants;
         this.courseData = raceData;
@@ -123,6 +123,17 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
         );
         gameView.setBoatAsPlayer(player);
         gameView.startRace();
+        raceState.addCollisionListener(gameView::drawCollision);
+        raceState.windDirectionProperty().addListener((obs, oldDirection, newDirection) -> {
+            gameView.setWindDir(newDirection.doubleValue());
+            updateWindDirection(newDirection.doubleValue());
+        });
+        for (ClientYacht yacht : participants.values()) {
+            yacht.placingProperty().addListener((obs, oldPlacing, newPlacing) -> {
+                updateOrder();
+                updateSparkLine();
+            });
+        }
     }
 
     /**
@@ -208,10 +219,9 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 
 
     /**
-     * Used to add any new yachts into the race that may have started late or not have had data
-     * received yet
+     * Used to add any new yachts into the race that may have started late or not have had data received yet
      */
-    private void updateSparkLine() {
+    private void updateSparkLine(){
         // TODO: 2/08/17 there is about 0 chance of this working. Once we are keeping track of boat positions it can be fixed.
         // Collect the racing yachts that aren't already in the chart
         sparkLineData.clear();
@@ -219,40 +229,39 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
         // Create a new data series for new yachts
         sparkLineCandidates
             .stream()
-            .filter(yacht -> yacht.getPositionInteger() != null)
+            .filter(yacht -> yacht.getPlacing() != null)
             .forEach(yacht -> {
                 Series<String, Double> yachtData = new Series<>();
                 yachtData.setName(yacht.getSourceId().toString());
                 yachtData.getData().add(
                     new XYChart.Data<>(
                         Integer.toString(yacht.getLegNumber()),
-                        1.0 + participants.size() - yacht.getPositionInteger()
+                        1.0 + participants.size() - yacht.getPlacing()
                     )
                 );
-                sparkLineData.add(yachtData);
+            sparkLineData.add(yachtData);
             });
 
         // Lambda function to sort the series in order of leg (later legs shown more to the right)
         sparkLineData.sort((o1, o2) -> {
-            Integer leg1 = Integer.parseInt(o1.getData().get(o1.getData().size() - 1).getXValue());
-            Integer leg2 = Integer.parseInt(o2.getData().get(o2.getData().size() - 1).getXValue());
-            if (leg2 < leg1) {
+            Integer leg1 =  Integer.parseInt(o1.getData().get(o1.getData().size()-1).getXValue());
+            Integer leg2 =  Integer.parseInt(o2.getData().get(o2.getData().size()-1).getXValue());
+            if (leg2 < leg1){
                 return 1;
             } else {
                 return -1;
             }
         });
         // Adds the new data series to the sparkline (and set the colour of the series)
-        Platform.runLater(() ->
+        Platform.runLater(() -> {
             sparkLineData
                 .stream()
                 .filter(spark -> !raceSparkLine.getData().contains(spark))
                 .forEach(spark -> {
                     raceSparkLine.getData().add(spark);
-                    spark.getNode().lookup(".chart-series-line")
-                        .setStyle("-fx-stroke:" + getBoatColorAsRGB(spark.getName()));
-                })
-        );
+                    spark.getNode().lookup(".chart-series-line").setStyle("-fx-stroke:" + getBoatColorAsRGB(spark.getName()));
+                });
+        });
     }
 
     private void initialiseSparkLine() {
@@ -262,15 +271,15 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 
     /**
      * Updates the yachts sparkline of the desired yacht and using the new leg number
-     * @param clientYacht The yacht to be updated on the sparkline
+     * @param yacht The yacht to be updated on the sparkline
      * @param legNumber the leg number that the position will be assigned to
      */
-    void updateYachtPositionSparkline(ClientYacht clientYacht, Integer legNumber) {
+    void updateClientYachtPositionSparkline(ClientYacht yacht, Integer legNumber){
         for (XYChart.Series<String, Double> positionData : sparkLineData) {
             positionData.getData().add(
                 new Data<>(
                     Integer.toString(legNumber),
-                    1.0 + participants.size() - clientYacht.getPositionInteger()
+                    1.0 + participants.size() - yacht.getPlacing()
                 )
             );
         }
@@ -278,7 +287,7 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 //        positionData.getData().add(
 //            new XYChart.Data<>(
 //                Integer.toString(legNumber),
-//                1.0 + participants.size() - yacht.getPosition()
+//                1.0 + participants.size() - yacht.getPlacing()
 //            )
 //        );
     }
@@ -286,52 +295,47 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 
     /**
      * gets the rgb string of the yachts colour to use for the chart via css
-     *
      * @param yachtId id of yacht passed in to get the yachts colour
      * @return the colour as an rgb string
      */
-    private String getBoatColorAsRGB(String yachtId) {
+    private String getBoatColorAsRGB(String yachtId){
         Color color = participants.get(Integer.valueOf(yachtId)).getColour();
-        if (color == null) {
-            return String.format("#%02X%02X%02X", 255, 255, 255);
+        if (color == null){
+            return String.format("#%02X%02X%02X",255,255,255);
         }
-        return String.format("#%02X%02X%02X",
-            (int) (color.getRed() * 255),
-            (int) (color.getGreen() * 255),
-            (int) (color.getBlue() * 255)
+        return String.format( "#%02X%02X%02X",
+            (int)( color.getRed() * 255 ),
+            (int)( color.getGreen() * 255 ),
+            (int)( color.getBlue() * 255 )
         );
     }
 
 
     /**
      * Initialises a timer which updates elements of the RaceView such as wind direction, yacht
-     * orderings etc.. which are dependent on the info from the stream parser constantly. Updates of
-     * each of these attributes are called ONCE EACH SECOND
+     * orderings etc.. which are dependent on the info from the stream parser constantly.
+     * Updates of each of these attributes are called ONCE EACH SECOND
      */
     private void initializeUpdateTimer() {
         timer.scheduleAtFixedRate(new TimerTask() {
             @Override
             public void run() {
                 updateRaceTime();
-                updateWindDirection();
-                updateOrder();
-//                updateSparkLine();
             }
         }, 0, 1000);
     }
 
     /**
-     * Iterates over all corners until ones SeqID matches with the yachts current leg number. Then
-     * it gets the compoundMarkID of that corner and uses it to fetch the appropriate mark Returns
-     * null if no next mark found.
-     *
+     * Iterates over all corners until ones SeqID matches with the yachts current leg number.
+     * Then it gets the compoundMarkID of that corner and uses it to fetch the appropriate mark
+     * Returns null if no next mark found.
      * @param bg The BoatGroup to find the next mark of
      * @return The next Mark or null if none found
      */
     private Mark getNextMark(BoatObject bg) {
         // TODO: 1/08/17 Move to GameView
 //
-//        Integer legNumber = bg.getYacht().getLegNumber();
+//        Integer legNumber = bg.getClientYacht().getLegNumber();
 //        List<Corner> markSequence = courseData.getMarkSequence();
 //
 //        if (legNumber == 0) {
@@ -352,10 +356,11 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 
     /**
      * Updates the wind direction arrow and text as from info from the StreamParser
+     * @param direction the from north angle of the wind.
      */
-    private void updateWindDirection() {
-        windDirectionText.setText(String.format("%.1f°", raceState.getWindDirection()));
-        windArrowText.setRotate(raceState.getWindDirection());
+    private void updateWindDirection(double direction) {
+        windDirectionText.setText(String.format("%.1f°", direction));
+        windArrowText.setRotate(direction);
     }
 
 
@@ -376,25 +381,20 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
      * section
      */
     private void updateOrder() {
-//        positionVbox.getChildren().removeAll();
-//        positionVbox.getStylesheets().add(getClass().getResource("/css/master.css").toString());
-
-        // list of racing yacht id
         List<ClientYacht> sorted = new ArrayList<>(participants.values());
-        sorted.sort(Comparator.comparingInt(ClientYacht::getPositionInteger));
+        sorted.sort(Comparator.comparingInt(ClientYacht::getPlacing));
         List<Text> vboxEntries = new ArrayList<>();
 
-        for (ClientYacht clientYacht : sorted) {
-//            System.out.println("yacht == null  " + String.valueOf(yacht == null));
-            if (clientYacht.getBoatStatus() == 3) {  // 3 is finish status
-                Text textToAdd = new Text(clientYacht.getPositionInteger() + ". " +
-                    clientYacht.getShortName() + " (Finished)");
+        for (ClientYacht yacht : sorted) {
+            if (yacht.getBoatStatus() == 3) {  // 3 is finish status
+                Text textToAdd = new Text(yacht.getPlacing() + ". " +
+                    yacht.getShortName() + " (Finished)");
                 textToAdd.setFill(Paint.valueOf("#d3d3d3"));
                 vboxEntries.add(textToAdd);
 
             } else {
-                Text textToAdd = new Text(clientYacht.getPositionInteger() + ". " +
-                    clientYacht.getShortName() + " ");
+                Text textToAdd = new Text(yacht.getPlacing() + ". " +
+                    yacht.getShortName() + " ");
                 textToAdd.setFill(Paint.valueOf("#d3d3d3"));
                 textToAdd.setStyle("");
                 vboxEntries.add(textToAdd);
@@ -403,13 +403,6 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
         Platform.runLater(() ->
             positionVbox.getChildren().setAll(vboxEntries)
         );
-//            participants.forEach((id, yacht) ->{
-//                Text textToAdd = new Text(yacht.getPosition() + ". " +
-//                    yacht.getShortName() + " ");
-//                textToAdd.setFill(Paint.valueOf("#d3d3d3"));
-//                textToAdd.setStyle("");
-//                positionVbox.getChildren().add(textToAdd);
-//            });
     }
 
 
@@ -478,17 +471,15 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
     }
 
 
-    private Point2D getPointRotation(Point2D ref, Double distance, Double angle) {
-        Double newX = ref.getX() + (ref.getX() + distance - ref.getX()) * Math.cos(angle)
-            - (ref.getY() + distance - ref.getY()) * Math.sin(angle);
-        Double newY = ref.getY() + (ref.getX() + distance - ref.getX()) * Math.sin(angle)
-            + (ref.getY() + distance - ref.getY()) * Math.cos(angle);
+    private Point2D getPointRotation(Point2D ref, Double distance, Double angle){
+        Double newX = ref.getX() + (ref.getX() + distance -ref.getX())*Math.cos(angle) - (ref.getY() + distance -ref.getY())*Math.sin(angle);
+        Double newY = ref.getY() + (ref.getX() + distance -ref.getX())*Math.sin(angle) + (ref.getY() + distance -ref.getY())*Math.cos(angle);
 
         return new Point2D(newX, newY);
     }
 
 
-    public Line makeLeftLayline(Point2D startPoint, Double layLineAngle, Double baseAngle) {
+    public Line  makeLeftLayline(Point2D startPoint, Double layLineAngle, Double baseAngle) {
 
         Point2D ep = getPointRotation(startPoint, 50.0, baseAngle + layLineAngle);
         Line line = new Line(startPoint.getX(), startPoint.getY(), ep.getX(), ep.getY());
@@ -507,8 +498,8 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 
 
     /**
-     * Initialised the combo box with any yachts currently in the race and adds the required
-     * listener for the combobox to take action upon selection
+     * Initialised the combo box with any yachts currently in the race and adds the required listener
+     * for the combobox to take action upon selection
      */
     private void initialiseBoatSelectionComboBox() {
         yachtSelectionComboBox.setItems(
@@ -545,7 +536,7 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
             TimeUnit.MILLISECONDS.toHours(milliseconds),
             TimeUnit.MILLISECONDS.toMinutes(milliseconds) % 60, //Modulus 60 minutes per hour
             TimeUnit.MILLISECONDS.toSeconds(milliseconds) % 60  //Modulus 60 seconds per minute
-        );
+            );
     }
 
     private void setAnnotations(Integer annotationLevel) {
@@ -580,9 +571,9 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
     /**
      * Sets all the annotations of the selected yacht to be visible and all others to be hidden
      *
-     * @param clientYacht The yacht for which we want to view all annotations
+     * @param yacht The yacht for which we want to view all annotations
      */
-    private void setSelectedBoat(ClientYacht clientYacht) {
+    private void setSelectedBoat(ClientYacht yacht) {
 //        for (BoatObject bg : gameViewController.getBoatGroups()) {
 //            //We need to iterate over all race groups to get the matching yacht group belonging to this yacht if we
 //            //are to toggle its annotations, there is no other backwards knowledge of a yacht to its yachtgroup.
@@ -596,23 +587,8 @@ public class RaceViewController extends Thread implements ImportantAnnotationDel
 //        }
     }
 
-    public void updateRaceData(RaceXMLData raceData) {
+    public void updateRaceData (RaceXMLData raceData) {
         this.courseData = raceData;
         gameView.updateBorder(raceData.getCourseLimit());
     }
-
-    /**
-     * Called by game client after receiving yacht event packet. Parameter subject id is the
-     * offending yacht. This function in turn will pass the yacht location to game view to display a
-     * collision alert.
-     *
-     * @param subjectId source id of offending yacht
-     */
-    public void showCollision(Long subjectId) {
-        gameView.drawCollision(participants.get((int) (long) subjectId).getLocation());
-    }
-
-    public GameView getGameView() {
-        return gameView;
-    }
 }

src/main/java/seng302/visualiser/fxObjects/BoatObject.java

@@ -11,6 +11,7 @@ import javafx.scene.paint.Paint;
 import javafx.scene.shape.Line;
 import javafx.scene.shape.Polygon;
 import javafx.scene.shape.Polyline;
+import javafx.scene.shape.StrokeLineCap;
 import javafx.scene.transform.Rotate;
 
 /**
@@ -352,7 +353,8 @@ public class BoatObject extends Group {
             BOAT_WIDTH / 1.75, BOAT_HEIGHT / 1.75
         );
         boatPoly.setStroke(Color.BLACK);
-        boatPoly.setStrokeWidth(3);
+        boatPoly.setStrokeWidth(2);
+        boatPoly.setStrokeLineCap(StrokeLineCap.ROUND);
         isPlayer = true;
         animateSail();
     }

src/main/java/seng302/visualiser/fxObjects/Marker.java

@@ -32,15 +32,29 @@ public class Marker extends Group {
     public void constructArrows(MarkArrowFactory.RoundingSide roundingSide, double entryAngle, double exitAngle) {
         enterArrow = MarkArrowFactory.constructEntryArrow(roundingSide, entryAngle, exitAngle, colour);
         exitArrow = MarkArrowFactory.constructExitArrow(roundingSide, exitAngle, colour);
-        Platform.runLater(() -> this.getChildren().add(enterArrow));
-//        Platform.runLater(() -> this.getChildren().add(exitArrow));
     }
 
     public void showEnterArrow () {
-        Platform.runLater(() -> this.getChildren().setAll(enterArrow));
+        if (!this.getChildren().contains(enterArrow)) {
+            Platform.runLater(() -> {
+                this.getChildren().remove(exitArrow);
+                this.getChildren().add(enterArrow);
+            });
+        }
     }
 
     public void showExitArrow () {
-        Platform.runLater(() -> this.getChildren().setAll(exitArrow));
+        if (!this.getChildren().contains(exitArrow)) {
+            Platform.runLater(() -> {
+                this.getChildren().remove(enterArrow);
+                this.getChildren().add(exitArrow);
+            });
+        }
+    }
+
+    public void hideAllArows () {
+        Platform.runLater(() -> {
+            this.getChildren().removeAll(enterArrow, exitArrow);
+        });
     }
 }