From 7d0a47446dc777f67d85d9557c83a796960efdd6 Mon Sep 17 00:00:00 2001 From: Alistair McIntyre Date: Thu, 14 Sep 2017 13:02:31 +1200 Subject: [PATCH] - Fixed bug in customize dialog. tags : #story[1245] --- .../controllers/LobbyController.java | 5 +++-- .../dialogs/BoatCustomizeController.java | 9 ++++---- .../resources/css/dialogs/BoatCustomize.css | 11 +++++++--- .../views/dialogs/BoatCustomizeDialog.fxml | 22 ++++++++++++------- 4 files changed, 30 insertions(+), 17 deletions(-) diff --git a/src/main/java/seng302/visualiser/controllers/LobbyController.java b/src/main/java/seng302/visualiser/controllers/LobbyController.java index 9beb14f5..23502bf6 100644 --- a/src/main/java/seng302/visualiser/controllers/LobbyController.java +++ b/src/main/java/seng302/visualiser/controllers/LobbyController.java @@ -110,7 +110,6 @@ public class LobbyController implements Initializable { } private JFXDialog createCustomizeDialog() { - // TODO: 12/09/17 ajm412: Why is this here? is there no better way we can do this? Ideally inside the LobbyController. FXMLLoader dialog = new FXMLLoader( getClass().getResource("/views/dialogs/BoatCustomizeDialog.fxml")); @@ -119,7 +118,6 @@ public class LobbyController implements Initializable { try { customizationDialog = new JFXDialog(serverListMainStackPane, dialog.load(), JFXDialog.DialogTransition.CENTER); - } catch (IOException e) { e.printStackTrace(); } @@ -128,6 +126,9 @@ public class LobbyController implements Initializable { controller.setParentController(this); controller.setPlayerColor(this.playersColor); + controller.setPlayerName(this.playerBoats + .get(ViewManager.getInstance().getGameClient().getServerThread().getClientId()) + .getBoatName()); return customizationDialog; } diff --git a/src/main/java/seng302/visualiser/controllers/dialogs/BoatCustomizeController.java b/src/main/java/seng302/visualiser/controllers/dialogs/BoatCustomizeController.java index 16afa1e9..339f08b8 100644 --- a/src/main/java/seng302/visualiser/controllers/dialogs/BoatCustomizeController.java +++ b/src/main/java/seng302/visualiser/controllers/dialogs/BoatCustomizeController.java @@ -38,10 +38,6 @@ public class BoatCustomizeController implements Initializable{ @Override public void initialize(URL location, ResourceBundle resources) { - submitBtn.setOnMouseReleased(event -> { - Sounds.playButtonClick(); - submitCustomization(); - }); socketThread = ViewManager.getInstance().getGameClient().getServerThread(); @@ -53,6 +49,11 @@ public class BoatCustomizeController implements Initializable{ boatName.setValidators(playerNameLengthValidator, playerNameReqValidator); + submitBtn.setOnMouseReleased(event -> { + Sounds.playButtonClick(); + submitCustomization(); + }); + submitBtn.setOnMouseEntered(e -> Sounds.playHoverSound()); } diff --git a/src/main/resources/css/dialogs/BoatCustomize.css b/src/main/resources/css/dialogs/BoatCustomize.css index d706d970..9acf4403 100644 --- a/src/main/resources/css/dialogs/BoatCustomize.css +++ b/src/main/resources/css/dialogs/BoatCustomize.css @@ -1,6 +1,3 @@ -* { - -fx-text-fill: -fx-pp-dark-text-color; -} #submitBtn { -fx-background-color: -fx-pp-theme-color; @@ -23,7 +20,15 @@ -fx-font-size: 18px; } +#boatName, #boatColorLabel, #hostDialogHeader { + -fx-text-fill: -fx-pp-dark-text-color; +} + #boatName { -fx-font-size: 18px; -fx-prompt-text-fill: -fx-pp-dark-text-color; +} + +#boatName .error-label { + -fx-font-size: 13px; } \ No newline at end of file diff --git a/src/main/resources/views/dialogs/BoatCustomizeDialog.fxml b/src/main/resources/views/dialogs/BoatCustomizeDialog.fxml index 3b869ce1..8e8653cf 100644 --- a/src/main/resources/views/dialogs/BoatCustomizeDialog.fxml +++ b/src/main/resources/views/dialogs/BoatCustomizeDialog.fxml @@ -22,8 +22,10 @@ - - + +